[Merged by Bors] - chore: use skip instead of -failIfUnchanged in the default tactic of Homeomorph#39758
Closed
gasparattila wants to merge 1 commit into
Closed
Conversation
… of `Homeomorph`
PR summary 72f8cd4d03Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
github-actions
Bot
added
the
t-topology
Contributor
|
Thanks! Can you update the PR description to summarise why this is better? (Otherwise, this is ready to merge.) Are the other locations which benefit from this change? If so, do you mind updating them in this PR also? |
grunweg
added
the
awaiting-author
Contributor
Author
|
I've updated the description. I think this is the only default tactic with -awaiting-author |
github-actions
Bot
removed
the
awaiting-author
themathqueen
approved these changes
May 24, 2026
Contributor
|
Thanks! |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 24, 2026
… of `Homeomorph` (#39758) This way, we do not try to call `fun_prop` again when `dsimp` could not make any simplification. This makes a difference only when the default tactic fails, so this change should not affect working code.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
skip instead of -failIfUnchanged in the default tactic of Homeomorphskip instead of -failIfUnchanged in the default tactic of Homeomorph
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
… of `Homeomorph` (leanprover-community#39758) This way, we do not try to call `fun_prop` again when `dsimp` could not make any simplification. This makes a difference only when the default tactic fails, so this change should not affect working code.
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
… of `Homeomorph` (leanprover-community#39758) This way, we do not try to call `fun_prop` again when `dsimp` could not make any simplification. This makes a difference only when the default tactic fails, so this change should not affect working code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we do not try to call
fun_propagain whendsimpcould not make any simplification. This makes a difference only when the default tactic fails, so this change should not affect working code.See the discussion in #37386.